Skip to content

fix(use-image): resolve race condition with cached images on Firefox/Safari #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wingkwong merged 2 commits into from
Dec 27, 2025
Merged

fix(use-image): resolve race condition with cached images on Firefox/Safari #6041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f0ddf
fix(use-image): resolve race condition with cached images on Firefox/…
brianathere Dec 23, 2025
e7b5fe1
fix(use-image): add ignoreFallback to useCallback dependencies
brianathere Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .changeset/fix-use-image-race-condition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
"@heroui/use-image": patch
"@heroui/image": patch
"@heroui/avatar": patch
---

Fix race condition in use-image hook that caused cached images to remain invisible (stuck at opacity-0) on Firefox and Safari.

**Root Cause:**
Event handlers (`onload`/`onerror`) were attached AFTER setting the image `src`. For cached images, the browser fires `onload` synchronously when `src` is set, causing the event to be missed. This is particularly prevalent in Firefox and Safari due to their JavaScript execution timing characteristics.

**Solution:**
- Attach `onload`/`onerror` handlers BEFORE setting `src`
- Check both `naturalWidth` AND `naturalHeight` (per CodeRabbit review feedback on #4523)
- Handle synchronous error callbacks for failed cached images
- Include `ignoreFallback` in useCallback dependencies to prevent stale closures when prop changes dynamically
- Add comprehensive test coverage including synchronous callback scenarios and dynamic `ignoreFallback` changes

Fixes #4534, #2259
Loading
Loading