Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-laws-enjoy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@heroui/number-input": patch
---

allow inheriting labelPlacement from HeroUIProvider (#5845)
29 changes: 29 additions & 0 deletions packages/components/number-input/__tests__/number-input.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {render, fireEvent, act} from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import {useForm} from "react-hook-form";
import {Form} from "@heroui/form";
import {HeroUIProvider} from "@heroui/system";

import {NumberInput} from "../src";

Expand Down Expand Up @@ -680,4 +681,32 @@ describe("NumberInput with React Hook Form", () => {
});
});
});

describe("NumberInput with HeroUIProvider context", () => {
it("should inherit labelPlacement from HeroUIProvider", () => {
const {container} = render(
<HeroUIProvider labelPlacement="outside">
<NumberInput label="Test number input" />
</HeroUIProvider>,
);

const label = container.querySelector("label");

expect(label).toBeTruthy();
expect(label?.className).toMatch(/translate-y.*100%/);
});

it("should prioritize labelPlacement prop over HeroUIProvider context", () => {
const {container} = render(
<HeroUIProvider labelPlacement="outside">
<NumberInput label="Test number input" labelPlacement="inside" />
</HeroUIProvider>,
);

const label = container.querySelector("label");

expect(label).toBeTruthy();
expect(label?.className).not.toMatch(/translate-y.*100%/);
});
});
});
10 changes: 9 additions & 1 deletion packages/components/number-input/src/use-number-input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,18 @@ export function useNumberInput(originalProps: UseNumberInputProps) {
numberInput({
...variantProps,
isInvalid,
labelPlacement,
isClearable,
disableAnimation,
}),
[objectToDeps(variantProps), isInvalid, isClearable, hasStartContent, disableAnimation],
[
objectToDeps(variantProps),
isInvalid,
labelPlacement,
isClearable,
hasStartContent,
disableAnimation,
],
);

const handleKeyDown = useCallback(
Expand Down
Loading