Skip to content

fix(toast): Toast items close in reverse order #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wingkwong merged 6 commits into from
Jun 30, 2025
Merged

fix(toast): Toast items close in reverse order #5405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d088ae7
fix(toast): correct closing order to implement proper FIFO behavior
adi-ray Jun 20, 2025
ec97a10
chore(changeset): add changeset
adi-ray Jun 20, 2025
8a7acc2
fix(changeset): update issue number
wingkwong Jun 22, 2025
adbc535
chore(toast): use `!==` instead
wingkwong Jun 22, 2025
f0595f3
feat(toast): apply exit animation to auto-close timeout
adi-ray Jun 23, 2025
0bb3d94
Merge branch 'canary' into pr/5405
wingkwong Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/perfect-turtles-eat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@heroui/toast": patch
---

Fix toast items closing in reverse order. Toasts now close in proper FIFO instead of LIFO (#5096)
7 changes: 4 additions & 3 deletions packages/components/toast/src/use-toast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ export function useToast<T extends ToastProps>(originalProps: UseToastProps<T>)
}, []);

const [isLoading, setIsLoading] = useState<boolean>(!!promiseProp);
const [isToastExiting, setIsToastExiting] = useState(false);

useEffect(() => {
if (!promiseProp) return;
Expand All @@ -220,7 +221,7 @@ export function useToast<T extends ToastProps>(originalProps: UseToastProps<T>)
startTime.current = timestamp;
}

if (isToastHovered || isRegionExpanded || index != total - 1) {
if (isToastHovered || isRegionExpanded) {
pausedTime.current += timestamp - startTime.current;
startTime.current = null;
animationRef.current = requestAnimationFrame(updateProgress);
Expand All @@ -232,7 +233,7 @@ export function useToast<T extends ToastProps>(originalProps: UseToastProps<T>)

timeElapsed.current = elapsed;
if (timeElapsed.current >= timeout) {
state.close(toast.key);
setIsToastExiting(true);
}

progressRef.current = Math.min((elapsed / timeout) * 100, 100);
Expand Down Expand Up @@ -264,6 +265,7 @@ export function useToast<T extends ToastProps>(originalProps: UseToastProps<T>)
total,
isRegionExpanded,
isLoading,
setIsToastExiting,
]);

const Component = as || "div";
Expand All @@ -283,7 +285,6 @@ export function useToast<T extends ToastProps>(originalProps: UseToastProps<T>)
}, []);

const [initialHeight, setInitialHeight] = useState<number>(0);
const [isToastExiting, setIsToastExiting] = useState(false);

// Following was inspired from sonner ❤️
useLayoutEffect(() => {
Expand Down