Skip to content

fix(toast): fixed close button hover position #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wingkwong merged 15 commits into from
Jul 2, 2025
Merged

fix(toast): fixed close button hover position #5245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c6dd40f
fix(toast): fixed close button hover position
Vishvsalvi Apr 28, 2025
7d630f4
Update soft-spoons-march.md
Vishvsalvi Apr 28, 2025
bc547fc
Update toast.ts
Vishvsalvi May 30, 2025
20a1d7f
chore(theme): prettier
wingkwong May 31, 2025
3f05d9d
Using "placement" to apply the top and bottom extension
Vishvsalvi Jun 2, 2025
0eda676
fix(toast): modified hover for expanded region
Vishvsalvi Jun 27, 2025
9930a80
update dependancy array
Vishvsalvi Jun 27, 2025
fc0c816
lint fix
Vishvsalvi Jun 27, 2025
472a092
Merge branch 'canary' into pr/5245
wingkwong Jun 27, 2025
ecd4d25
Merge branch 'canary' into pr/5245
wingkwong Jun 27, 2025
fa066c7
chore(theme): remove line breaks
wingkwong Jun 27, 2025
75a227d
chore(changeset): add missing package
wingkwong Jun 27, 2025
cd5d311
static extension size
Vishvsalvi Jun 30, 2025
771c830
Merge branch 'heroui-inc:canary' into fix/issue_toast_button_close_po…
Vishvsalvi Jul 1, 2025
fb13a98
fix(toast): static extension fix
Vishvsalvi Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/soft-spoons-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@heroui/theme": patch
"@heroui/toast": patch
Comment thread
wingkwong marked this conversation as resolved.
---

Remove the bottom extenstion of the toast (#5231)
7 changes: 2 additions & 5 deletions packages/components/toast/src/use-toast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,11 +395,8 @@ export function useToast<T extends ToastProps>(originalProps: UseToastProps<T>)

const getToastProps: PropGetter = useCallback(
(props = {}) => {
const aboveToastHeight = index + 1 < total ? heights[index + 1] : 0;
const belowToastHeight = index - 1 >= 0 ? heights[index - 1] : 0;

const topExtension = aboveToastHeight ? Math.ceil(aboveToastHeight / 2) + 8 : 16;
const bottomExtension = belowToastHeight ? Math.ceil(belowToastHeight / 2) + 8 : 16;
const topExtension = 16;
const bottomExtension = 16;

const pseudoElementStyles = {
"--top-extension": `${topExtension}px`,
Expand Down
18 changes: 12 additions & 6 deletions packages/core/theme/src/components/toast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,23 +43,29 @@ const toast = tv({
"my-1",
"w-full sm:w-[356px]",
"min-h-4",

"before:content-['']",
"before:absolute",
"before:left-0",
"before:right-0",
"before:h-[var(--top-extension,16px)]",
"before:top-[calc(-1*var(--top-extension,16px))]",
"data-[placement=bottom-right]:before:h-[var(--top-extension,16px)]",
"data-[placement=bottom-left]:before:h-[var(--top-extension,16px)]",
"data-[placement=bottom-center]:before:h-[var(--top-extension,16px)]",
"data-[placement=bottom-right]:before:top-[calc(-1*var(--top-extension,16px))]",
"data-[placement=bottom-left]:before:top-[calc(-1*var(--top-extension,16px))]",
"data-[placement=bottom-center]:before:top-[calc(-1*var(--top-extension,16px))]",
"before:z-[-1]",
"before:pointer-events-auto",
"before:bg-transparent",

"after:content-['']",
"after:absolute",
"after:left-0",
"after:right-0",
"after:h-[var(--bottom-extension,16px)]",
"after:bottom-[calc(-1*var(--bottom-extension,16px))]",
"data-[placement=bottom-right]:after:h-[var(--bottom-extension,16px)]",
"data-[placement=bottom-left]:after:h-[var(--bottom-extension,16px)]",
"data-[placement=bottom-center]:after:h-[var(--bottom-extension,16px)]",
"data-[placement=bottom-right]:after:bottom-[calc(-1*var(--bottom-extension,16px))]",
"data-[placement=bottom-left]:after:bottom-[calc(-1*var(--bottom-extension,16px))]",
"data-[placement=bottom-center]:after:bottom-[calc(-1*var(--bottom-extension,16px))]",
"after:z-[-1]",
"after:pointer-events-auto",
"after:bg-transparent",
Expand Down