Skip to content

Fix 44/input helpertext color#45

Merged
jrgarciadev merged 4 commits into
mainfrom
fix_44/input-helpertext-color
Sep 26, 2021
Merged

Fix 44/input helpertext color#45
jrgarciadev merged 4 commits into
mainfrom
fix_44/input-helpertext-color

Conversation

@jrgarciadev
Copy link
Copy Markdown
Member

Close #44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Only
  • Refactor

Description, Motivation and Context

New prop added to Input for customising helper colour separately

Screenshots - Animations

@jrgarciadev jrgarciadev self-assigned this Sep 26, 2021
@jrgarciadev jrgarciadev added the ✨ Type: Enhancement New enhancement on existing codebase label Sep 26, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #45 (902abfe) into main (9acda7b) will increase coverage by 0.09%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   95.16%   95.26%   +0.09%     
==========================================
  Files          66       66              
  Lines        1054     1055       +1     
  Branches      372      372              
==========================================
+ Hits         1003     1005       +2     
  Misses         45       45              
+ Partials        6        5       -1     
Impacted Files Coverage Δ
...ackages/nextui/src/components/input/input-props.ts 100.00% <ø> (ø)
...s/nextui/src/components/input/input-icon-clear.tsx 82.60% <66.66%> (+5.33%) ⬆️
packages/nextui/src/components/input/input.tsx 96.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9acda7b...902abfe. Read the comment docs.

@jrgarciadev jrgarciadev merged commit dd3e2ae into main Sep 26, 2021
@jrgarciadev jrgarciadev deleted the fix_44/input-helpertext-color branch March 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Type: Enhancement New enhancement on existing codebase

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Input] Add another property for customising the helperText color

2 participants