Skip to content

fix(alert): mark description optional & revise styles when only children is provided #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrgarciadev merged 3 commits into from
Dec 27, 2024
Merged

fix(alert): mark description optional & revise styles when only children is provided #4447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1ed4b6
fix(alert): mark description as optional and update description
wingkwong Dec 26, 2024
316ef1b
fix(theme): alignment when only children is provided
wingkwong Dec 26, 2024
2b9ffa8
feat(changeset): add changeset
wingkwong Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-badgers-beam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/alert": patch
---

mark description prop as optional (#4445)
5 changes: 5 additions & 0 deletions .changeset/new-cups-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/theme": patch
---

fix the alignment when only alert children is provided
4 changes: 2 additions & 2 deletions packages/components/alert/src/use-alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ interface Props extends HTMLNextUIProps<"div"> {
*/
title?: string;
/**
* Main body of the alert message
* description of the alert message
*/
description: ReactNode;
description?: ReactNode;
/**
* Icon to be displayed in the alert - overrides the default icon
*/
Expand Down
3 changes: 2 additions & 1 deletion packages/core/theme/src/components/alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ import {colorVariants} from "../utils";
const alert = tv({
slots: {
base: "flex flex-grow flex-row w-full items-start py-3 px-4 gap-x-1",
mainWrapper: "h-full flex-grow min-h-10 ms-2 flex flex-col box-border items-start text-inherit",
mainWrapper:
"h-full flex-grow min-h-10 ms-2 flex flex-col box-border items-start text-inherit justify-center",
title: "text-small w-full font-medium block text-inherit leading-5",
description: "pl-[1px] text-small font-normal text-inherit",
closeButton: "relative text-inherit translate-x-1 -translate-y-1",
Expand Down