Skip to content

fix(autocomplete): highlight item in AutocompleteSection during keyboard navigation #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wingkwong merged 1 commit into from
Sep 7, 2024
Merged

fix(autocomplete): highlight item in AutocompleteSection during keyboard navigation #3726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popular-baboons-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/listbox": patch
---

Fix item highlighting in `AutocompleteSection` during keyboard navigation (#3713)
10 changes: 3 additions & 7 deletions packages/components/listbox/src/use-listbox-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,9 @@ export function useListboxItem<T extends object>(originalProps: UseListboxItemPr
itemProps = removeEvents(itemProps);
}

const isHighlighted = useMemo(() => {
if (shouldHighlightOnFocus && isFocused) {
return true;
}

return isMobile ? isHovered || isPressed : isHovered;
}, [isHovered, isPressed, isFocused, isMobile, shouldHighlightOnFocus]);
const isHighlighted =
(shouldHighlightOnFocus && isFocused) ||
(isMobile ? isHovered || isPressed : isHovered || (isFocused && !isFocusVisible));

const getItemProps: PropGetter = (props = {}) => ({
ref: domRef,
Expand Down