Skip to content

fix(system-rsc): missing StringToBoolean<keyof V[K]>[] #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wingkwong merged 8 commits into from
Aug 29, 2024
Merged

fix(system-rsc): missing StringToBoolean<keyof V[K]>[] #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4543e1
fix(navbar): fixed the height when style h-full
awesome-pro Jul 21, 2024
626e0e0
fix(navbar): fixed the height when style h-full
awesome-pro Jul 21, 2024
9ae43dd
Merge branch 'nextui-org:canary' into canary
awesome-pro Jul 23, 2024
816e5cb
Merge branch 'nextui-org:canary' into canary
awesome-pro Jul 25, 2024
97a40af
fix(core): string[] accepted by compoundVariants.variant
awesome-pro Jul 25, 2024
8db5157
Delete .changeset/brown-days-applaud.md
awesome-pro Jul 25, 2024
beff335
chore(changeset): revise changeset message
wingkwong Aug 17, 2024
c4592c9
fix(system-rsc): incorrect VariantValue typing and typo in Options
wingkwong Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-beans-thank.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/system-rsc": patch
---

added missing `StringToBoolean<keyof V[K]>[]` (#3530)
3 changes: 2 additions & 1 deletion packages/core/system-rsc/src/extend-variants.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ type ComposeVariants<CP, S> = SuggestedVariants<CP, S> | Variants<S>;
type VariantValue<V, SV> = {
[K in keyof V | keyof SV]?:
| (K extends keyof V ? StringToBoolean<keyof V[K]> : never)
| (K extends keyof V ? StringToBoolean<keyof V[K]>[] : never)
| (K extends keyof SV
? ValidateSubtype<SV[K], object> extends "true"
? keyof OmitUndefined<SV[K]>
Expand All @@ -47,7 +48,7 @@ type CompoundVariants<V, SV> = Array<VariantValue<V, SV> & ClassProp<ClassValue>
type Options = {
/**
* Whether to merge the class names with `tailwind-merge` library.
* It's avoid to have duplicate tailwind classes. (Recommended)
* It avoids to have duplicate tailwind classes. (Recommended)
* @see https://github.com/dcastil/tailwind-merge/blob/v1.8.1/README.md
* @default true
*/
Expand Down