Skip to content

fix(theme): double click issue on checkbox, toggle and radio #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wingkwong merged 5 commits into from
Aug 29, 2024
Merged

fix(theme): double click issue on checkbox, toggle and radio #3552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4543e1
fix(navbar): fixed the height when style h-full
awesome-pro Jul 21, 2024
626e0e0
fix(navbar): fixed the height when style h-full
awesome-pro Jul 21, 2024
9ae43dd
Merge branch 'nextui-org:canary' into canary
awesome-pro Jul 23, 2024
7832f81
fix(checkbox): double click need in chrome
awesome-pro Jul 24, 2024
670a48a
Delete .changeset/brown-days-applaud.md
awesome-pro Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-crabs-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/theme": patch
---

fixed the double click need in chrome for checkbox, switch and radiobuttons (#3528)
2 changes: 1 addition & 1 deletion packages/core/theme/src/components/checkbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {groupDataFocusVisibleClasses} from "../utils";
*/
const checkbox = tv({
slots: {
base: "group relative max-w-fit inline-flex items-center justify-start cursor-pointer tap-highlight-transparent p-2 -m-2",
base: "group relative max-w-fit inline-flex items-center justify-start cursor-pointer tap-highlight-transparent p-2 -m-2 select-none",
wrapper: [
"relative",
"inline-flex",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/theme/src/components/radio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {groupDataFocusVisibleClasses} from "../utils";
*/
const radio = tv({
slots: {
base: "group relative max-w-fit inline-flex items-center justify-start cursor-pointer tap-highlight-transparent p-2 -m-2",
base: "group relative max-w-fit inline-flex items-center justify-start cursor-pointer tap-highlight-transparent p-2 -m-2 select-none",
wrapper: [
"relative",
"inline-flex",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/theme/src/components/toggle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {groupDataFocusVisibleClasses} from "../utils";
*/
const toggle = tv({
slots: {
base: "group relative max-w-fit inline-flex items-center justify-start cursor-pointer touch-none tap-highlight-transparent",
base: "group relative max-w-fit inline-flex items-center justify-start cursor-pointer touch-none tap-highlight-transparent select-none",
wrapper: [
"px-1",
"relative",
Expand Down