Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-ducks-do.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/input": patch
---

syncs changes to ref value to internal (state) value (#3024, #3436)
20 changes: 20 additions & 0 deletions packages/components/input/__tests__/input.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,26 @@ describe("Input", () => {
expect(ref.current?.value)?.toBe(value);
});

it("setting ref should sync the internal value", () => {
const ref = React.createRef<HTMLInputElement>();

const {container} = render(<Input ref={ref} type="text" />);

if (!ref.current) {
throw new Error("ref is null");
}

ref.current!.value = "value";

const input = container.querySelector("input")!;

input.focus();

const internalValue = input.value;

expect(ref.current?.value)?.toBe(internalValue);
});

it("should clear the value and onClear is triggered", async () => {
const onClear = jest.fn();

Expand Down
38 changes: 36 additions & 2 deletions packages/components/input/src/use-input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {useDOMRef, filterDOMProps} from "@nextui-org/react-utils";
import {useFocusWithin, useHover, usePress} from "@react-aria/interactions";
import {clsx, dataAttr, isEmpty, objectToDeps, safeAriaLabel, warn} from "@nextui-org/shared-utils";
import {useControlledState} from "@react-stately/utils";
import {useMemo, Ref, useCallback, useState} from "react";
import {useMemo, Ref, useCallback, useState, useImperativeHandle, useRef} from "react";
import {chain, mergeProps} from "@react-aria/utils";
import {useTextField} from "@react-aria/textfield";

Expand Down Expand Up @@ -131,7 +131,41 @@ export function useInput<T extends HTMLInputElement | HTMLTextAreaElement = HTML
const disableAnimation =
originalProps.disableAnimation ?? globalContext?.disableAnimation ?? false;

const domRef = useDOMRef<T>(ref);
const domRef = useRef<T>(null);

let proxy: T | undefined = undefined;

useImperativeHandle(
ref,
() => {
if (proxy === undefined) {
proxy = new Proxy(domRef.current!, {
get(target, prop) {
const value = target[prop];

if (value instanceof Function) {
return value.bind(target);
}

return value;
},
set(target, prop, value) {
target[prop] = value;

if (prop === "value") {
setInputValue(value);
}

return true;
},
});
}

return proxy;
},
[domRef.current],
);

const baseDomRef = useDOMRef<HTMLDivElement>(baseRef);
const inputWrapperRef = useDOMRef<HTMLDivElement>(wrapperRef);
const innerWrapperRef = useDOMRef<HTMLDivElement>(innerWrapperRefProp);
Expand Down