Skip to content

refactor(input): input ref test #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrgarciadev merged 2 commits into from
Mar 31, 2024
Merged

refactor(input): input ref test #2613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a099726
refactor(input): remove duplicate test
wingkwong Mar 31, 2024
0338d1b
refactor(input): remove unncessary waitFor
wingkwong Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions packages/components/input/__tests__/input.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from "react";
import {render, waitFor} from "@testing-library/react";
import {render} from "@testing-library/react";

import {Input} from "../src";

Expand Down Expand Up @@ -99,7 +99,8 @@ describe("Input", () => {

expect(onFocus).toHaveBeenCalledTimes(1);
});
it("ref should update the value", async () => {

it("ref should update the value", () => {
const ref = React.createRef<HTMLInputElement>();

const {container} = render(<Input ref={ref} type="text" />);
Expand All @@ -113,11 +114,6 @@ describe("Input", () => {

container.querySelector("input")?.focus();

await waitFor(() => {
return expect(ref.current?.value)?.toBe(value);
});
await waitFor(() => {
return expect(ref.current?.value)?.toBe(value);
});
expect(ref.current?.value)?.toBe(value);
});
});