Skip to content

fix(components): isdisabled does not disable dropdown #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrgarciadev merged 1 commit into from
Mar 3, 2024
Merged

fix(components): isdisabled does not disable dropdown #2435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/two-lobsters-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nextui-org/dropdown": major
---

Fixed the bug: isDisabled does not disable dropdown
4 changes: 2 additions & 2 deletions packages/components/dropdown/src/use-dropdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,15 @@ export function useDropdown(props: UseDropdownProps) {
});

const getMenuTriggerProps: PropGetter = (
props = {},
originalProps = {},
_ref: Ref<any> | null | undefined = null,
) => {
// These props are not needed for the menu trigger since it is handled by the popover trigger.
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const {onKeyDown, onPress, onPressStart, ...otherMenuTriggerProps} = menuTriggerProps;

return {
Copy link
Copy Markdown
Author

@harukikuri harukikuri Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important here to use props.isDisabled so that the PopoverTrigger component can respect another isDisabled gets passed by the user. (Otherwise, the unit test is going to fail.)

...mergeProps(otherMenuTriggerProps, props),
...mergeProps(otherMenuTriggerProps, {isDisabled: props.isDisabled, originalProps}),
ref: mergeRefs(_ref, triggerRef),
};
};
Expand Down