Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Proxies to support urls with query strings #139

Closed
wei opened this issue Aug 29, 2019 · 1 comment
Closed

Proxies to support urls with query strings #139

wei opened this issue Aug 29, 2019 · 1 comment

Comments

@wei
Copy link

wei commented Aug 29, 2019

As titled, with this static.json file,

{
  "proxies": {
    "/authenticate/": {
      "origin": "https://github.com/login/oauth/access_token?client_id=${GITHUB_CLIENT_ID}&client_secret=${CLIENT_SECRET}&code="
    }
  }
}

Ideally /authenticate/${code} should proxy to https://github.com/login/oauth/access_token?client_id=${GITHUB_CLIENT_ID}&client_secret=${CLIENT_SECRET}&code=${code}.

Right now it drops the paths & query string and proxies to https://github.com/

@edmorley
Copy link
Member

edmorley commented Jun 9, 2022

Hi

This buildpack is now deprecated and we are recommending people move the more actively maintained heroku-buildpack-nginx. For migration advice see here.

As such, I'm closing this issue out since we won't be making further changes to this buildpack.

@edmorley edmorley closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants