Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Can't set "Keep-Alive" header #137

Closed
dalyr95 opened this issue Aug 15, 2019 · 1 comment
Closed

Can't set "Keep-Alive" header #137

dalyr95 opened this issue Aug 15, 2019 · 1 comment

Comments

@dalyr95
Copy link

dalyr95 commented Aug 15, 2019

In safari when dealing with video/audio media makes the assumption that it's streaming media unless there's a keep-alive header with a max and timeout. I've tried setting this in the static.json like so;

{
  "clean_urls": true,
  "https_only": true,
  "root": "dist/",
  "routes": {
    "/assets/*": "/assets/",
    "/**": "index.html"
  },
  "headers": {
    "/assets/**": {
      "Cache-Control": "public, max-age=31557600"
    },
    "/assets/shutter.mp3": {
      "Content-Range": "bytes */69072",
      "Cache-Control": "public, max-age=86400",
      "Keep-Alive": "timeout=2, max=100"
    }
  }
}

I can see Content-Range and Cache Control is being set, but not keep alive. Looking through the nginx config, looks like there is a 5 second keepalive default, can we expose this default header or be able to change it?

@edmorley
Copy link
Member

edmorley commented Jun 9, 2022

Hi

This buildpack is now deprecated and we are recommending people move the more actively maintained heroku-buildpack-nginx. For migration advice see here.

As such, I'm closing this issue out since we won't be making further changes to this buildpack.

@edmorley edmorley closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants