Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest version of setuptools for Python 3. #973

Closed
wants to merge 1 commit into from

Conversation

rvanlaar
Copy link

@rvanlaar rvanlaar commented May 4, 2020

Python2 stays on the original vendered setuptools: 39.0.1.

Python2 stays on the original vendered setuptools: 39.0.1.

Force installation of new setuptools.

Fix python version check.

iasdfasdf
@rvanlaar
Copy link
Author

rvanlaar commented May 4, 2020

Would need an extra check for setuptools to update it when the current version is lower.

edmorley added a commit that referenced this pull request Jul 30, 2020
Upgrades setuptools from 39.0.1 to:
- 44.1.1 for Python 2.7 (since it's the last supported version)
- 43.0.0 for Python 3.4 (since it's the last supported version)
- 47.1.1 for Python 3.5+ (since we can't use 47.2.0+ until #1006 fixed)

https://setuptools.readthedocs.io/en/latest/history.html#v47-1-1

Fixes #949.
Closes #973.
@edmorley edmorley mentioned this pull request Jul 30, 2020
@edmorley edmorley changed the base branch from master to main August 3, 2020 13:29
edmorley added a commit that referenced this pull request Aug 3, 2020
Upgrades setuptools from 39.0.1 to:
- 44.1.1 for Python 2.7 (since it's the last supported version)
- 43.0.0 for Python 3.4 (since it's the last supported version)
- 47.1.1 for Python 3.5+ (since we can't use 47.2.0+ until #1006 fixed)

https://setuptools.readthedocs.io/en/latest/history.html#v47-1-1

Fixes #949.
Closes #973.
edmorley added a commit that referenced this pull request Aug 3, 2020
Upgrades setuptools from 39.0.1 to:
- 44.1.1 for Python 2.7 (since it's the last supported version)
- 43.0.0 for Python 3.4 (since it's the last supported version)
- 47.1.1 for Python 3.5+ (since we can't use 47.2.0+ until #1006 fixed)

https://setuptools.readthedocs.io/en/latest/history.html#v47-1-1

Fixes #949.
Closes #973.
@edmorley
Copy link
Member

edmorley commented Aug 3, 2020

@rvanlaar thank you for the PR! The handling of pip/setuptools changed quite a bit in #1007 which caused conflicts in this PR, and handling also needed to be added for Python 3.4 (since the latest setuptools that supports it is 43.0.0) - so I ended up fixing this in #1024.

dryan pushed a commit to dryan/heroku-buildpack-python that referenced this pull request Nov 19, 2020
Upgrades setuptools from 39.0.1 to:
- 44.1.1 for Python 2.7 (since it's the last supported version)
- 43.0.0 for Python 3.4 (since it's the last supported version)
- 47.1.1 for Python 3.5+ (since we can't use 47.2.0+ until heroku#1006 fixed)

https://setuptools.readthedocs.io/en/latest/history.html#v47-1-1

Fixes heroku#949.
Closes heroku#973.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants