Update puts-step "Installing pip" #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @CaseyFaist, here's the new PR. I wish you happy holidays and a happy new year :) |
Since the output of the actual pip install is redirected into /dev/null, one never knows (by just reading the deploy output) which pip version is installed. Adding the version to the puts-step should make for quicker debugging.
JanNash
force-pushed
the
improve-output-of-python-step
branch
from
97d0971 to
f918fdb
Compare
|
Superceded by #939 (I cherry picked your commit in so you still get the credit 👍 ), tests in progress. |
That's very kind of you :D (I didn't do this for the credit, just to improve things, but I still appreciate it :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the output of the actual pip install is redirected into /dev/null, one never knows (by just reading the deploy output) which pip version is installed. Adding the version to the puts-step should make for quicker debugging.
On another note:
Personally, I'd also be in favour of making it possible to configure the pip version that should be installed via a config variable. If this is wanted, I'll gladly work on it and submit a PR.