Make the BUILD_WITH_GEO_LIBRARIES warning fatal #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
geos-warning-fatal
branch
from
78213cb to
d61fd60
Compare
The `BUILD_WITH_GEO_LIBRARIES` feature was removed in the previous PR, and replaced with a warning that the feature is no longer supported. After further thought I believe it would be best to make this warning fatal, to prevent unexpected failures at runtime, if consumers of the library either aren't invoked during the build, or were previously installed/cached and were dynamically linked against the library. Continuation of #1113 / @W-7654424@.
edmorley
force-pushed
the
geos-warning-fatal
branch
from
d61fd60 to
ce06583
Compare
danielleadams
approved these changes
Nov 11, 2020
Merged
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
The `BUILD_WITH_GEO_LIBRARIES` feature was removed in the previous PR, and replaced with a warning that the feature is no longer supported. After further thought I believe it would be best to make this warning fatal, to prevent unexpected failures at runtime, if consumers of the library either aren't invoked during the build, or were previously installed/cached and were dynamically linked against the library. Continuation of heroku#1113 / @W-7654424@.
edmorley
added a commit
that referenced
this pull request
Aug 15, 2022
Since: - the error has been in place since Nov 2020 (#1115), so the vast majority of apps/users will have already seen it - even without this explicit check, if a GDAL install fails we still print the standard instructions via the warnings system: https://github.com/heroku/heroku-buildpack-python/blob/5f896a434c29c6835395083503f4768457e9adc1/bin/warnings#L49-L58 https://github.com/heroku/heroku-buildpack-python/blob/5f896a434c29c6835395083503f4768457e9adc1/spec/hatchet/pip_spec.rb#L227-L240 GUS-W-11593037.
pull bot
pushed a commit
to eloisetwaine/heroku-buildpack-python
that referenced
this pull request
Aug 15, 2022
Since: - the error has been in place since Nov 2020 (heroku#1115), so the vast majority of apps/users will have already seen it - even without this explicit check, if a GDAL install fails we still print the standard instructions via the warnings system: https://github.com/heroku/heroku-buildpack-python/blob/5f896a434c29c6835395083503f4768457e9adc1/bin/warnings#L49-L58 https://github.com/heroku/heroku-buildpack-python/blob/5f896a434c29c6835395083503f4768457e9adc1/spec/hatchet/pip_spec.rb#L227-L240 GUS-W-11593037.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BUILD_WITH_GEO_LIBRARIESfeature was removed in the previous PR, and replaced with a warning that the feature is no longer supported.After further thought I believe it would be best to make this warning fatal, to prevent unexpected failures at runtime, if consumers of the library either aren't invoked during the build, or were previously installed/cached and were dynamically linked against the library.
Continuation of #1113 / W-7654424.