Emit metrics for how the Python version was chosen #1069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an app's Python version can be set via a few different means:
runtime.txt
orPipfile.lock
)In order to determine the priority of features like automatic Python patch version upgrades for sticky-versioned apps, it's useful to have metrics for these.
There were previously no tests for either the sticky versions feature, or changing the Python version by updating the
runtime.txt
file, so I've added some now (given that I updated the conditional to add the metrics, so useful to have coverage).I've also removed the confusing overwrite of
DEFAULT_PYTHON_VERSION
with the cached version, and kept them as two separate variables.Closes W-8099632.
Closes W-8099645.