Allow for custom mime.types file in project config folder #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beanieboi
approved these changes
Aug 9, 2019
|
@jgarber623 thank you so much, thats a great PR. |
|
Thanks for the quick review and merge, @beanieboi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if my project includes a file
config/mime.typesadjacent toconfig/nginx.conf.erb, the buildpack will overwrite it (see lines 16 and 17 inbin/compile).This pull request adds a check for an existing
config/mime.typesfile and, if present, leaves it in place. The behavior is exactly the same as the succeeding compile step for theconfig/nginx.conf.erbfile.Thanks for taking a look!