Allow for Test re-runs #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/multiple-ci-runs
branch
from
16d70e1
to
6dda682
Compare
I needed to run a test twice to assert that the cache was used for the Ruby buildpack. I hacked it: https://github.com/heroku/heroku-buildpack-ruby/blob/facd23708feff15d5bdbfd0455dc470a21b11a76/spec/hatchet/ci_spec.rb#L41-L43 This PR gives a supported API instead to call `TestRun#run_again`. While working on this, I discovered that the test run wasn't being run inside the temp directory. So I fixed that bug, I also added support for `before_deploy`.
schneems
force-pushed
the
schneems/multiple-ci-runs
branch
from
6dda682
to
2c8a04d
Compare
danielleadams
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to run a test twice to assert that the cache was used for the Ruby buildpack. I hacked it:
https://github.com/heroku/heroku-buildpack-ruby/blob/facd23708feff15d5bdbfd0455dc470a21b11a76/spec/hatchet/ci_spec.rb#L41-L43
This PR gives a supported API instead to call
TestRun#run_again.While working on this, I discovered that the test run wasn't being run inside the temp directory. So I fixed that bug, I also added support for
before_deploy.