Remove/reduce warnings #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bundler command is being deprecated: ``` [DEPRECATED] `Bundler.with_clean_env` has been deprecated in favor of `Bundler.with_unbundled_env`. If you instead want the environment before bundler was originally loaded, use `Bundler.with_original_env` (called at /home/travis/build/heroku/hatchet/lib/hatchet/app.rb:418) ``` We're using it in places where we were shelling out to `heroku`. I believe this was because the `heroku` cli used to be distributed as a ruby gem and in case the user did not have it in their Gemfile then the command would fail. The `heroku` command hasn't been distributed as a gem for a long time so I believe we can safely remove this, but the tests and time will tell.
schneems
force-pushed
the
schneems/fix-warnings
branch
from
3c6deed
to
3ee841f
Compare
Mocha deprecation warning at /home/travis/build/heroku/hatchet/test/test_helper.rb:10:in `require': Require 'mocha/test_unit', 'mocha/minitest' or 'mocha/api' instead of 'mocha/setup'.
danielleadams
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.