[Close #71] Do not escape to local system shell #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/multi-commands-run
branch
from
a6c7332
to
ec55d4d
Compare
schneems
force-pushed
the
schneems/multi-commands-run
branch
from
f7c7147
to
91c80c2
Compare
Malax
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
I think this is an improvement to the previous behaviour, even if it breaks backwards compat again. I had to change my specs for work when I updated hatchet to work with the "raw by default" feature. But I really didn't need the feature. Having raw as opt-in makes sense to me.
dzuelke
approved these changes
Apr 15, 2020
Right now if someone wrote this code:
```
app.run("ls && rm -rf /")
```
It would be interpreted as:
```
$ heroku run ls
$ rm -rf /
```
Which is surprising at best and harmful at worst. This PR auto escapes commands by default. This was the default behavior before 59f76d4 which removed shellescape-ing, but this edge case was not considered.
If the user wants more flexibility, they can specify they're using their own escaping by passing in `raw: true`.
I also updated the method signature for `App#run` so that the `heroku:` option can be used without having to specify a `nil` argument in the middle, I'm deprecating the ReplRunner interface (which was pretty broken and I don't believe used) so that we can simplify the method signature in the future.
schneems
force-pushed
the
schneems/multi-commands-run
branch
from
6fea687
to
014c343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if someone wrote this code:
It would be interpreted as:
Which is surprising at best and harmful at worst. This PR auto escapes commands by default. This was the default behavior before 59f76d4 which removed shellescape-ing, but this edge case was not considered.
If the user wants more flexibility, they can specify they're using their own escaping by passing in
raw: true.I also updated the method signature for
App#runso that theheroku:option can be used without having to specify anilargument in the middle, I'm deprecating the ReplRunner interface (which was pretty broken and I don't believe used) so that we can simplify the method signature in the future.