Use TRAVIS_PULL_REQUEST_BRANCH over TRAVIS_BRANCH if available #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
HATCHET_BUILDPACK_BRANCH
norHEROKU_TEST_RUN_BRANCH
are set, Hatchet falls back toHatchet.git_branch
which tries to resolve the branch using git. Before using actual git, it will look for theTRAVIS_BRANCH
environment variable and use its value if available instead.TRAVIS_BRANCH
works fine unless the build is a pull-request. In that case, it will contain the target branch not the actual pull-request branch. This results in Hatchet tests running silently against the target branch (most of the timemaster
) and not testing the actual changes in the PR.TRAVIS_PULL_REQUEST_BRANCH
contains the correct branch but will be empty for push builds.See: https://docs.travis-ci.com/user/environment-variables/