Heroku CI fixes #68
Merged
Heroku CI fixes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a CI run finishes, the associated ephemeral app created for the test run internally gets removed almost immediately the system then sees a pipeline with no apps, and deletes it, also almost immediately that does, with bad timing, lead to our test run info poll in wait\! to return 403, and/or in the delete_pipeline at the end so we set up the app if not already done, and then connect it to the pipeline we created pipeline gets removed at the end, which leaves the app intact the app will be collected by Reaper sometime later if needed
dzuelke
force-pushed
the
ci_fixes
branch
4 times, most recently
from
f87b593
to
b1a2376
Compare
|
Thanks! I released this in version 4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is a race condition with CI runs. After the CI build finishes, then the pipeline it is run against doesn't have any apps associated with it. When Heroku sees a pipeline with no apps, it will delete the pipeline. When this happens in a Hatchet powered test then a 403 response will be raised when we manually try to destroy the pipeline since Heroku already purged it.
The workaround
To work around this behavior, we manually create an app and attach it to a pipeline so that Heroku will not delete the pipeline before we are done using it.
This PR
app.jsonif set, otherwise tests always run on heroku-18testenvinapp.json, so config set on the app makes it into the test run