app.run fixes #58
Merged
app.run fixes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
reviewed
Mar 7, 2019
by passing nil
dzuelke
force-pushed
the
app-run-fixes
branch
4 times, most recently
from
cb05ff4
to
4a94675
Compare
and separate using double dash avoids any possible conflicts between `heroku run` options and program options, e.g. when running `ls -a foo` this also means it's no longer necessary to shell-escape the command (which would previously turn it into a single string, which the Heroku CLI then unpacked again)
can be tested afterwards using $?.exitstatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-notify) by passingnilas the value--$?.exitstatusI wonder if we should not
.to_s.shellescapethecommandpart now. It leads to the whole thing being one quoted string, which the CLI then unpacks again: https://github.com/heroku/cli/blob/master/packages/run-v5/lib/helpers.js#L6-L10All that potentially leads to is quoting madness in special cases; changing it as well should not impact any existing calls