Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale to size 'basic' in App.teardown! #193

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Scale to size 'basic' in App.teardown! #193

merged 1 commit into from
Jan 23, 2023

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Jan 23, 2023

Scaling to size 'free' is no longer possible, so this is now causing test failures for users of run_multi

GUS-W-12421816

Scaling to size 'free' is no longer possible, so this is now causing test failures for users of run_multi

GUS-W-12421816
@dzuelke
Copy link
Contributor Author

dzuelke commented Jan 23, 2023

Failures previously (422 error from API on scaling down): https://github.com/heroku/heroku-buildpack-php/actions/runs/3930613528

Works with this change: https://github.com/heroku/heroku-buildpack-php/actions/runs/3988477263 (has the change from this branch monkey patched)

Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@schneems schneems merged commit 96435d6 into main Jan 23, 2023
@schneems schneems deleted the scale-to-basic branch January 23, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants