Add branch detection for more CI providers #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
requested changes
Sep 30, 2022
|
Not sure how I missed this coming in. Ready to merge? |
|
Needs a changelog |
schneems
force-pushed
the
jwl/branch-detection
branch
from
e64dfbc
to
3d52719
Compare
|
I rebased and pushed to your branch, also added a changelog entry |
edmorley
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Circle CI, GitHub Actions, and Heroku CI are widely used internally and across the ecosystem, I thought it might make sense to centralize this detection. Otherwise, we're looking at copying it around as discussed in heroku/heroku-buildpack-nodejs#1033 (review) and #179.