Use the standalone installer for 'ci:install_heroku' rather than APT #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the APT installer takes 3.5x longer than the non-APT version, and offers little benefit in a CI environment. Closes #169.
edmorley
force-pushed
the
edmorley/heroku-install-non-apt
branch
from
1ca3956
to
bb03e4b
Compare
|
Dang! Great find |
edmorley
added a commit
to heroku/heroku-buildpack-python
that referenced
this pull request
Feb 17, 2021
Since it's now ok to rely on `hatchet ci:setup` installing the CLI for us, after: heroku/hatchet#171
edmorley
added a commit
to heroku/heroku-buildpack-python
that referenced
this pull request
Feb 17, 2021
* CI: Remove manual Heroku CLI install step Since it's now ok to rely on `hatchet ci:setup` installing the CLI for us, after: heroku/hatchet#171 * Tests: Switch to `HATCHET_DEFAULT_STACK` See: https://github.com/heroku/hatchet#env-vars * Tests: Remove `new_app()` helper Now that we no longer need to set default options. * Tests: Remove unused method `run!` Closes GUS-W-8900415.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the APT installer takes 3.5x longer than the non-APT version, and offers little benefit in a CI environment.
Closes #169.