Don't use &. #139
Closed
Don't use &. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't specify a required_ruby_version, so this change makes Hatchet incompatible with Ruby pre-2.7. That causes platform-api's tests to fail as they test against Rubies back to 2.2. See for example [this failing CircleCI job](https://app.circleci.com/pipelines/github/heroku/platform-api/79/workflows/ec4d33f1-8596-4604-a742-59beec4951d7/jobs/428).
calebhearth
force-pushed
the
fix-ruby-incompatibility
branch
from
a8a0ac2
to
8bd7de7
Compare
|
Merged in #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't specify a required_ruby_version, so this change makes Hatchet
incompatible with Ruby pre-2.7. That causes platform-api's tests to fail
as they test against Rubies back to 2.2.
See for example this failing CircleCI job.
This should resolve the fialing builds on
heroku/platform-api#110.