[close #83] HATCHET_BUILDPACK_BASE updates #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if you want to set HATCHET_BUILDPACK_BASE, you need to do so before you `require 'hatchet'` which is unexpected. By evaluating this env var every time a new app is created it allows the developer to set this env var when they want instead of before requiring the library. The other change here is to no longer default to a buildpack. While it was useful for defaulting to the Ruby buildpack when only the ruby buildpack used this library, it is confusing when setting up a new buildpack to have deploys seemingly happen but it to not use your buildpack code. This can be fixed by raising a helpful error when HATCHET_BUILDPACK_BASE is not set. However that's a breaking change. For now I'm just deprecating that fallback behavior.
schneems
force-pushed
the
schneems/lazy-env-vars
branch
from
0eba099
to
15daa21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you want to set HATCHET_BUILDPACK_BASE, you need to do so before you
require 'hatchet'which is unexpected. By evaluating this env var every time a new app is created it allows the developer to set this env var when they want instead of before requiring the library.The other change here is to no longer default to a buildpack. While it was useful for defaulting to the Ruby buildpack when only the ruby buildpack used this library, it is confusing when setting up a new buildpack to have deploys seemingly happen but it to not use your buildpack code. This can be fixed by raising a helpful error when HATCHET_BUILDPACK_BASE is not set. However that's a breaking change. For now I'm just deprecating that fallback behavior.