[close #129] Ignore 403 on deleting pipeline #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/rescuepipeline403
branch
from
708e9cb
to
72371db
Compare
edmorley
reviewed
Sep 21, 2020
| @@ -495,6 +495,9 @@ def create_source | |||
|
|
|||
| def delete_pipeline(pipeline_id) | |||
| api_rate_limit.call.pipeline.delete(pipeline_id) | |||
| rescue Excon::Error::Forbidden | |||
| warn "Error deleting pipeline id: #{pipeline_id.inspect}, status: 403" | |||
| # Means the pipeline likely doesn't exist, not sure why though | |||
There was a problem hiding this comment.
@schneems There is a pipeline cleaner that removes any pipelines that contain zero apps, shortly after an app in a pipeline is deleted. I would imagine the pipeline delete races with that. In these cases the pipeline delete could just be skipped entirely, since the pipeline cleaner will take care of it.
There was a problem hiding this comment.
Good call. Makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.