Throttle on Unhandled rate limit #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's pretty expensive to generate this key. Without memoization: ``` $ be rspec spec/unit/shell_throttle_spec.rb Finished in 9.01 seconds (files took 0.3817 seconds to load) ``` With memoization: ``` $ be rspec spec/unit/shell_throttle_spec.rb Finished in 4.2 seconds (files took 0.51638 seconds to load) ```
Tracked in: #127 - Unhandled rate limit - Incident 1 - Logs: https://gist.github.com/schneems/be8b7ee0e9ec3b1d8d1e83f13e35ce27 - link: https://app.circleci.com/pipelines/github/heroku/hatchet/206/workflows/c5b3126a-3b36-4bc5-98fb-77d997432ae2/jobs/597 - Incident 2 - Link https://app.circleci.com/pipelines/github/heroku/hatchet/204/workflows/8b77d5f5-0057-484e-989a-dd0dc8d1a88e/jobs/593 - incident 3 - link https://app.circleci.com/pipelines/github/heroku/hatchet/216/workflows/bea5f936-8682-4b92-ac75-69abc3a6386c/jobs/632 ``` Retrying failed Attempt #1/3 to push for 'hatchet-t-a2291a3e46' due to error: Hatchet::App::FailedDeployError Could not deploy 'hatchet-t-a2291a3e46' (default_ruby) using 'Hatchet::GitApp' at path: 'repo_fixtures/repos/default/default_ruby' if this was expected add `allow_failure: true` to your deploy hash. Buildpack: nil Repo: https://git.heroku.com/hatchet-t-a2291a3e46.git output: error: RPC failed; HTTP 429 curl 22 The requested URL returned error: 429 Too Many Requests fatal: the remote end hung up unexpectedly fatal: the remote end hung up unexpectedly Everything up-to-date ``` Also renamed the shell throttle spec file to end in `_spec.rb` and decided it's a good place for the app git tests since they're not deploying code and are more unit-test ish and it's good to stub out the sleep in one place.
schneems
force-pushed
the
schneems/moar-429-retry
branch
from
052a8f4
to
04decae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #127
Also renamed the shell throttle spec file to end in
_spec.rband decided it's a good place for the app git tests since they're not deploying code and are more unit-test ish and it's good to stub out the sleep in one place.