Move disk modifying operations out of setup!
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/safe-setup
branch
from
9b2c52b
to
56260d9
Compare
schneems
force-pushed
the
schneems/safe-setup
branch
2 times, most recently
from
c036b82
to
a3114df
Compare
As described in heroku/heroku-buildpack-ruby#1061 it's possible to accidentally modify disk when you didn't intend to using the `setup!` API. This PR fixes that by moving all the disk mutating calls to it's own method and ensuring it only gets called while in the directory.
schneems
force-pushed
the
schneems/safe-setup
branch
from
a3114df
to
57cf2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in heroku/heroku-buildpack-ruby#1061 it's possible to accidentally modify disk when you didn't intend to using the
setup!API. This PR fixes that by moving all the disk mutating calls to it's own method and ensuring it only gets called while in the directory.