Fix support for deploying main branch
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I shipped support for the main branch I only checked that the lock file correctly installed the main branch, but never checked it could be deployed. In our deploy we previously ran `git push heroku master` which is short for `git push master:master` and this fails since there's no master branch of that repo. This force deploys HEAD instead.
schneems
force-pushed
the
schneems/fix-main
branch
from
bffb3c2
to
ce2ca1d
Compare
edmorley
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I shipped support for the main branch I only checked that the lock file correctly installed the main branch, but never checked it could be deployed.
In our deploy we previously ran
git push heroku masterwhich is short forgit push master:masterand this fails since there's no master branch of that repo. This force deploys HEAD instead.