fix: yarn downgrade for oclif linux release fixes (#2230)

* fix: revert to yarn 1. Attempt to reimplement ryandagg/oclif/apps-upgrade-ESLINT-FIXES which has passing tests

* chore: continue to re-implement

* fix: revert to previously successful lock file and re-install
remove duplice lint rule.

* chore: revert to --frozen-lockfile for yarn 1 installs.
set up CI to validate change

* chore: revert checks in sign_deb. Move checks for deb & tarballs to only stop uploads; we need these to be tested on PRs.

* fix: correct indentation

* fix: maybe correct syntax for conditional in CI

.eslintignore

@@ -1,3 +1,5 @@
 node_modules
 packages/*/lib
 packages/*/tmp
+tmp
+dst

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
           cache: yarn
-      - run: yarn --immutable --network-timeout 1000000
+      - run: yarn --frozen-lockfile --network-timeout 1000000
       - run: yarn test
 
   acceptance:
@@ -37,7 +37,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
           cache: yarn
-      - run: yarn --immutable --network-timeout 1000000
+      - run: yarn --frozen-lockfile --network-timeout 1000000
       - run: ./bin/run whoami
       - run: ./scripts/run-acceptance
 
@@ -50,7 +50,6 @@ jobs:
         working-directory: /
 
   pack_deb:
-    if: github.ref == 'refs/heads/master' || github.ref_type == 'tag' && startsWith(github.ref_name, 'v' )
     runs-on: ubuntu-latest
     env:
       HEROKU_AUTHOR: 'Heroku'
@@ -65,16 +64,16 @@ jobs:
         run: |
           cp yarn.lock packages/cli
           cd packages/cli
-          yarn --immutable --network-timeout 1000000
+          yarn --frozen-lockfile --network-timeout 1000000
       - name: Building deb
         run: ./scripts/pack/deb
       - uses: actions/upload-artifact@v3
+        if: github.ref == 'refs/heads/master' || github.ref_type == 'tag' && startsWith(github.ref_name, 'v' )
         with:
           name: packed-deb
           path: /home/runner/work/cli/cli/packages/cli/dist
 
   pack_tarballs:
-    if: github.ref == 'refs/heads/master' || github.ref_type == 'tag' && startsWith(github.ref_name, 'v' )
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -87,10 +86,11 @@ jobs:
         run: |
           cp yarn.lock packages/cli
           cd packages/cli
-          yarn --immutable --network-timeout 1000000
+          yarn --frozen-lockfile --network-timeout 1000000
       - name: Building tarballs
         run: ./scripts/pack/tarballs
       - uses: actions/upload-artifact@v3
+        if: github.ref == 'refs/heads/master' || github.ref_type == 'tag' && startsWith(github.ref_name, 'v' )
         with:
           name: packed-tarballs
           path: /home/runner/work/cli/cli/packages/cli/dist
@@ -155,7 +155,7 @@ jobs:
         run: |
           cp yarn.lock packages/cli
           cd packages/cli
-          yarn --immutable --prefer-offline --network-timeout 1000000
+          yarn --frozen-lockfile --prefer-offline --network-timeout 1000000
       - name: Upload production artifacts
         run: |
           cd packages/cli
@@ -207,7 +207,7 @@ jobs:
       - run: |
           cp yarn.lock packages/cli
           cd packages/cli
-          yarn --immutable --network-timeout 1000000
+          yarn --frozen-lockfile --network-timeout 1000000
           ./scripts/release/homebrew.js
 
   change-management:
@@ -224,5 +224,5 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - run: |
-          yarn --immutable --network-timeout 1000000
+          yarn --frozen-lockfile --network-timeout 1000000
           ./scripts/postrelease/change_management

package.json

@@ -20,10 +20,8 @@
     ]
   },
   "engines": {
-    "node": ">=12.0.0",
-    "yarn": ">=3.0.0"
+    "node": ">=12.0.0"
   },
-  "packageManager": "[email protected]",
   "private": true,
   "scripts": {
     "test": "lerna run test --concurrency 4",

packages/apps/.eslintrc

@@ -3,5 +3,7 @@
     "oclif",
     "oclif-typescript"
   ],
-  "rules": {}
+  "rules": {
+    "camelcase": "off"
+  }
 }

packages/auth/.eslintrc

@@ -3,5 +3,7 @@
     "oclif",
     "oclif-typescript"
   ],
-  "rules": {}
+  "rules": {
+    "camelcase": "off"
+  }
 }

packages/autocomplete/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/buildpacks/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/certs/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/ci/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/ci/test/commands/ci/run.test.ts

@@ -206,7 +206,7 @@ describe('ci:run', () => {
         got,
         'stream',
         // disable below is due to incomplete type definition of `stub`
-        // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         // @ts-ignore-next-line
         gotFake.stream,
       )

packages/cli/.eslintrc

@@ -3,5 +3,7 @@
     "oclif",
     "oclif-typescript"
   ],
-  "rules": {}
+  "rules": {
+    "camelcase": "off"
+  }
 }

packages/config/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/git/.eslintrc

@@ -5,6 +5,7 @@
   ],
   "rules": {
     "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off",
 
   }
 }

packages/local/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/oauth/.eslintrc

@@ -3,5 +3,7 @@
     "oclif",
     "oclif-typescript"
   ],
-  "rules": {}
+  "rules": {
+    "camelcase": "off"
+  }
 }

packages/ps/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": "off"
+    "unicorn/no-abusive-eslint-disable": "off",
+    "camelcase": "off"
   }
 }

packages/run/.eslintrc

@@ -4,6 +4,7 @@
     "oclif-typescript"
   ],
   "rules": {
-    "unicorn/no-abusive-eslint-disable": 0
+    "unicorn/no-abusive-eslint-disable": 0,
+    "camelcase": "off"
   }
 }

packages/run/test/commands/run.test.ts

@@ -11,7 +11,7 @@ describeOrSkip('@acceptance run', () => {
     return test
     .stdout()
     .do(() => {
-      // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       process.stdout.isTTY = false
     })

packages/status/.eslintrc

@@ -3,5 +3,7 @@
     "oclif",
     "oclif-typescript"
   ],
-  "rules": {}
+  "rules": {
+    "camelcase": "off"
+  }
 }

packages/webhooks/.eslintrc

@@ -3,5 +3,7 @@
     "oclif",
     "oclif-typescript"
   ],
-  "rules": {}
+  "rules": {
+    "camelcase": "off"
+  }
 }