Skip process registration with Procfile #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process types are not added to the launch table, and only there for informational purposes (e.g. to guide users to commands they may want to add to the Procfile)
This also avoids potential errors by only checking if Procfile exists once
runesoerensen
force-pushed
the
skip-process-registration-with-procfile
branch
from
1ecd3f7 to
f1e53f0
Compare
colincasey
approved these changes
Jan 24, 2025
heroku-linguist bot
added a commit
that referenced
this pull request
Feb 10, 2025
## heroku/dotnet ### Changed - Detected process types are now only registered as launch processes when no Procfile is present. [#185](#185) ### Added - Enabled `libcnb`'s `trace` feature. [#184](#184) ### Changed - The .NET SDK inventory was updated with new download URLs for version 9.0 release artifacts. [#193](#193)
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Feb 10, 2025
## heroku/dotnet ### Changed - Detected process types are now only registered as launch processes when no Procfile is present. [#185](#185) ### Added - Enabled `libcnb`'s `trace` feature. [#184](#184) ### Changed - The .NET SDK inventory was updated with new download URLs for version 9.0 release artifacts. [#193](#193) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Feb 10, 2025
## heroku/dotnet ### Changed - Detected process types are now only registered as launch processes when no Procfile is present. [#185](heroku/buildpacks-dotnet#185) ### Added - Enabled `libcnb`'s `trace` feature. [#184](heroku/buildpacks-dotnet#184) ### Changed - The .NET SDK inventory was updated with new download URLs for version 9.0 release artifacts. [#193](heroku/buildpacks-dotnet#193)
runesoerensen
added a commit
to heroku/heroku-buildpack-dotnet
that referenced
this pull request
Feb 10, 2025
heroku-linguist bot
added a commit
to heroku/heroku-buildpack-dotnet
that referenced
this pull request
Feb 10, 2025
* Update DOTNET_CNB_VERSION version to 0.2.0 * Update test to reflect new CNB output Related PR: heroku/buildpacks-dotnet#185 * Update changelog entries * Remove whitespace --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Rune Soerensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the automatic launch process registration logic, so detected process types are only added to the launch table when no
Procfileis found.The buildpack still prints detected process type names and commands for guidance (e.g. to allow users to easily copy commands to their own
Procfile).This also provides a mechanism for users to opt out of the launch process registration logic (as mentioned in #49).
Also see this related PR: heroku/buildpacks-go#319