Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Add documentation #18

Merged
merged 15 commits into from
Jul 10, 2021
Merged

Add documentation #18

merged 15 commits into from
Jul 10, 2021

Conversation

marot
Copy link
Contributor

@marot marot commented Jun 18, 2021

No description provided.

Cargo.toml Show resolved Hide resolved
src/default_client.rs Outdated Show resolved Hide resolved
src/default_client.rs Outdated Show resolved Hide resolved
src/default_client.rs Outdated Show resolved Hide resolved
src/default_client.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@marot marot marked this pull request as ready for review June 18, 2021 19:46
src/web_socket.rs Outdated Show resolved Hide resolved
src/web_socket.rs Show resolved Hide resolved
examples/async.rs Outdated Show resolved Hide resolved
@@ -12,6 +12,186 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//! # Rust client guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of doing this in lib.rs vs README.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only one would be that it will be added to the crate documentation when publishing. The readme could link to the documentation. Do you have any preferences?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marot is it possible to have the README be the "source of truth" and then have that added procedurally to the crate documentation? If that's too much fuss or not possible then having the readme link to the documentation sounds okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it is not too easy, because the examples contain code that is supposed to be hidden (setup code).

I will link to the documentation for now.

Copy link
Contributor

@lugehorsam lugehorsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fantastic.

@lugehorsam
Copy link
Contributor

@marot could you add documentation on the thread safety of the client?

@ValorZard
Copy link

Is this ready to be merged?

@marot
Copy link
Contributor Author

marot commented Jun 26, 2021

Hi @ValorZard
Not yet, I still need to provide a little bit more documentation on the websocket methods

@marot marot merged commit 794efe0 into heroiclabs:master Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants