Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fs-related helper functions #804

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Nov 21, 2024

This should help us keep up with the increasing complexity of the tests (including for features currently being developed). verify_file_equals is not particularly useful right now, but I intend on using it more intensively for the UhyveFileMap feature much more extensively.

@n0toose
Copy link
Member Author

n0toose commented Nov 21, 2024

my local rust-analyzer is drunk, thought this was good to go... fixing

@n0toose n0toose force-pushed the small-test-refactor branch 3 times, most recently from 1327207 to dcf7764 Compare November 21, 2024 14:48
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (0d9d0f2) to head (140f72d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          19       19           
  Lines        2568     2568           
=======================================
  Hits         1716     1716           
  Misses        852      852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@n0toose
Copy link
Member Author

n0toose commented Nov 21, 2024

got a few panics earlier because I tried to remove a file with remove_dir_all - I thought that it worked, but turns out it doesn't.

rust-lang/rust#133298

tests/fs-test.rs Outdated Show resolved Hide resolved
This should help us keep up with the increasing complexity of the tests
(including for features currently being developed). verify_file_equals
is not particularly useful right now, but I intend on using it more
intensively for the UhyveFileMap feature much more extensively.
@jounathaen jounathaen added this pull request to the merge queue Nov 21, 2024
Merged via the queue into hermit-os:main with commit 993b694 Nov 21, 2024
10 checks passed
@jounathaen jounathaen deleted the small-test-refactor branch November 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants