Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xtask crate for kernel building #378

Merged
merged 3 commits into from
Mar 26, 2022
Merged

Add xtask crate for kernel building #378

merged 3 commits into from
Mar 26, 2022

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Feb 28, 2022

Closes hermit-os/hermit-rs#188.

This adds an xtask package, with two subcommands build and clippy.
build builds the kernel with the correct arguments and does any necessary post processing (symbol renaming).
clippy runs clippy on the kernel for multiple architectures (though only x86_64 at this time - see #381).

@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

Canceled.

@mkroening
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 26, 2022
@mkroening
Copy link
Member Author

bors cancel

@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

try

Build failed:

@mkroening
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 26, 2022
@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

try

Build failed:

@mkroening mkroening force-pushed the xtask branch 2 times, most recently from 2a4ad86 to 1855700 Compare March 26, 2022 13:31
@mkroening
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 26, 2022
@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

try

Build failed:

@stlankes
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Mar 26, 2022
@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

try

Build failed:

@mkroening
Copy link
Member Author

bors r=stlankes

bors bot added a commit that referenced this pull request Mar 26, 2022
378: Add xtask crate for kernel building r=stlankes a=mkroening

Closes hermit-os/hermit-rs#188.

This adds an xtask package, with two subcommands `build` and `clippy`.
`build` builds the kernel with the correct arguments and does any necessary post processing (symbol renaming).
`clippy` runs clippy on the kernel for multiple architectures (though only `x86_64` at this time - see #381).

Co-authored-by: Martin Kröning <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 26, 2022

Build failed:

@mkroening
Copy link
Member Author

bors retry

@bors bors bot merged commit 77da9f1 into hermit-os:master Mar 26, 2022
@mkroening mkroening deleted the xtask branch March 26, 2022 18:50
bors bot added a commit to hermit-os/hermit-rs that referenced this pull request Mar 26, 2022
242: build.rs: Use libhermit-rs xtask r=stlankes a=mkroening

Closes #188.
Closes #136. (The flag is now entirely handled by the kernel)

Depends on hermit-os/kernel#378.

This removes the dependency on cargo-binutils.

This moves the kernel build logic and it's post processing into the kernel repository.

Co-authored-by: Martin Kröning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move symbol renaming to libhermit-rs
2 participants