PR #112 requires a socket handle to consume the buffer #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a `handle` must be use to free the buffer
|
@mustermeiszer Or do I forget something? |
|
@stlankes device.rs looks good to me. What are the changes in the bw-benchmark-client good for? |
|
If the client use a non-blocking stream, the write operation is able to fail because the resources are temporarily not available. In this case, we have to reinitiate the last write operation. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in addition, we revised the benchmark to measure the stream bandwidth and supports now also non-blocking streams.