Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing kernel targets #202

Closed
wants to merge 3 commits into from
Closed

removing kernel targets #202

wants to merge 3 commits into from

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Jan 8, 2022

In #197 we discuss to use x86_64-unknown-none target instead of the special kernel target. Also the aarch64 port has to useaarch64-unknown-none-softfloat. The floating point unit should not use in the kernel space.

In hermit-os#197 we discuss to use x86_64-unknown-none target instead of
the special `kernel` target. Also the aarch64 port has to use
aarch64-unknown-none-softfloat. The floating point unit should not
use in the kernel space.
@stlankes
Copy link
Contributor Author

stlankes commented Jan 8, 2022

bors try

bors bot added a commit that referenced this pull request Jan 8, 2022
@bors
Copy link
Contributor

bors bot commented Jan 8, 2022

try

Build failed:

@mkroening
Copy link
Member

Does that mean, we'll produce ELF files without our magic number for now, @stlankes?

@stlankes
Copy link
Contributor Author

stlankes commented Jan 9, 2022

No, I still want to produce ELF files with the magic number for a standalone application. We are able to modify the number after building the library or before linking the application.

However, the target aarch64-unknown-none-softfloat doesn't build a dynamic relocatable library. If this will not changed, we need our own aarch64-unknown-hermitkernel target (see rust-lang/rust#92670). We need a kernel target to disable within the kernel the SIMD instruction and the red-zone.

@stlankes
Copy link
Contributor Author

stlankes commented Feb 1, 2022

At this stage, I don't think that we are able to switch aarch64-unknown-none-softfloat? @mkroening Do you think that we should use x86_64-unknown-none?

@mkroening
Copy link
Member

Should this be closed then, @stlankes? I'll have a look at aligning our x86 target with x86_64-unknown-none.

@mkroening
Copy link
Member

Resolved by hermit-os/kernel#395.

@mkroening mkroening closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants