fix(lens): toml: write support #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this gets merged please also adapt the NEWS file to mention arrays with more than 2 dimensions are not supported until further notice. |
g0hl1n
changed the title
The toml lens fails to save simple toml files due to problems with multi dimensional (>2) arrays. Therefore disable arrays with more than 2 dimensions for now to enable basic usage again. This commit fixes issue #715 by applying the suggested workaround. If anyone can come up with a better solution please feel free to do so. Fixes: 5e1cd31 (TOML lens (#91), 2018-11-29) Signed-off-by: Richard Leitner <[email protected]>
toml.io now provides a versioned reference URL, therefore use this instead of the old GitHub repo link. Signed-off-by: Richard Leitner <[email protected]>
Signed-off-by: Richard Leitner <[email protected]>
g0hl1n
changed the title
This test covers the bug described in issue #715. Signed-off-by: Richard Leitner <[email protected]>
The "Test: Toml.array_norec; Array of arrays" tested a 3 dimensional array. This commit fixes the test to actually test a 2 dimensional array. More than 2 dimensional arrays are currently not supported due to issue #715. Signed-off-by: Richard Leitner <[email protected]>
|
@raphink any questions or feedback on this PR? |
|
[PING] |
|
This solves the immediate problem, which is that the toml lens cannot save any files at all. @raphink did you want to add/change anything ? |
|
[PING] |
|
[PING] |
georgehansper
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toml lens fails to save simple toml files due to problems with multi
dimensional (>2) arrays.
Therefore disable arrays with more than 2 dimensions for now to enable
basic usage again.
This commit fixes issue #715 by applying the suggested workaround. If
anyone can come up with a better solution please feel free to do so.
Fixes: 5e1cd31 (TOML lens (#91), 2018-11-29)
Signed-off-by: Richard Leitner [email protected]