Update sshd lens to split additional list keys

[tedgarb]

Several configuration values used for setting crypto policy were being
incorrectly parsed as raw strings when they are in fact lists. Treat
them as such

Specifically:

• GSSAPIKexAlgorithms
• PubkeyAcceptedKeyTypes
• CASignatureAlgorithms

[raphink]

Thanks for this and sorry for the delay in reviewing it.

Could you please add unit tests for these new keys?

[tedgarb]

Apologies on the long delay here, I added the requested tests

[georgehansper]

Thanks for that.

Since we are updating the sshd lens, can I ask you to also change the following:

@@ -151,7 +151,10 @@ module Sshd =
 
   let lns = (entry | comment | empty)* . match*
 
-  let xfm = transform lns (incl "/etc/ssh/sshd_config")
+  let filter = (incl "/etc/ssh/sshd_config" )
+               . ( incl "/etc/ssh/sshd_config.d/*.conf" )
+
+  let xfm = transform lns filter
 
 (* Local Variables: *)
 (* mode: caml       *)

My default sshd_config includes the line
Include /etc/ssh/sshd_config.d/*.conf

The "include something.d/*" approach to managing configs is becoming more and more common, I notice.

[tedgarb]

Done!

[georgehansper]

Look Good To Me