Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properties: support "/" in property names #680

Merged
merged 1 commit into from
Jun 12, 2020
Merged

properties: support "/" in property names #680

merged 1 commit into from
Jun 12, 2020

Conversation

felixdoerre
Copy link
Contributor

No description provided.

@felixdoerre felixdoerre mentioned this pull request Jun 12, 2020
Closed
@felixdoerre felixdoerre force-pushed the java_properties_slash branch from 5b83f66 to 0779993 Compare June 12, 2020 07:20
@felixdoerre felixdoerre force-pushed the java_properties_slash branch from 0779993 to 1c31c85 Compare June 12, 2020 07:50
raphink
raphink approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now that it's possible!

@raphink raphink merged commit 4382a40 into hercules-team:master Jun 12, 2020
@felixdoerre felixdoerre deleted the java_properties_slash branch June 12, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphink raphink raphink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdoerre @raphink