Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lens Authinfo2 #649

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Add lens Authinfo2 #649

merged 2 commits into from
Oct 30, 2019

Conversation

Salokyn
Copy link
Contributor

@Salokyn Salokyn commented Oct 29, 2019

Closes #646

@Salokyn
Copy link
Contributor Author

Salokyn commented Oct 30, 2019

Did I miss something for the checks to run ?

@raphink
Copy link
Member

raphink commented Oct 30, 2019

Yes, you need to add the test to tests/Makefile.am

@raphink
Copy link
Member

raphink commented Oct 30, 2019

See 42a4045 for example

raphink
raphink approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphink raphink merged commit 00c29f3 into hercules-team:master Oct 30, 2019
@Salokyn Salokyn deleted the add-lens-authinfo2 branch October 30, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphink raphink raphink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lens] authinfo2 file for S3QL
2 participants
@Salokyn @raphink