Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #643 - Update of opendkim lens to match current opendkim.conf file format #644

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

doc75
Copy link
Contributor

@doc75 doc75 commented Aug 20, 2019

Modification done to match possible format of /etc/opendkim.conf file:

  • Allow string values to start with numbers [0-9] like in AutoRestartRate 10/1h
  • Allow string values to contain '/' like in TrustAnchorFile /usr/share/dns/root.key
  • Allow boolean values to start with uppercase letter: False, True, Yes, No
  • Add support of parameter LogWhy with boolean value.

doc75 added 2 commits August 20, 2019 16:28

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…dkim.conf file format
@doc75
Copy link
Contributor Author

doc75 commented Aug 20, 2019

I added a test to check the modifications, but I cannot see the opedkim tests being replayed while launching make check.
If you have any idea, let me know how to replay it, I'll be more than happy to replay the tests).

@raphink
Copy link
Member

raphink commented Aug 23, 2019

The tests are played in CI here https://travis-ci.org/hercules-team/augeas/builds/574425620#L3880

@raphink raphink merged commit b603ca3 into hercules-team:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants