Few improvements to the Mke2fs lens #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphink
reviewed
Aug 19, 2019
lenses/mke2fs.aug
Outdated
| @@ -34,6 +34,11 @@ let sep = IniFile.sep /=[ \t]*/ "=" | |||
| (* View: empty *) | |||
| let empty = IniFile.empty | |||
|
|
|||
| (* View: boolean value | |||
There was a problem hiding this comment.
This needs to be View: boolean for the doc to be properly generated
raphink
reviewed
Aug 19, 2019
| @@ -95,24 +130,12 @@ let defaults = IniFile.record defaults_title | |||
| * Group: FS_TYPES SECTION | |||
| *************************************************************************) | |||
There was a problem hiding this comment.
Is there a reason for reorganizing these entries under common?
There was a problem hiding this comment.
You mean all the content of fs_types_entry? As I wrote in the commit message, the documentation says that they are allowed both in [defaults], and for each tag in [fs_types]. Since common_entry represents exactly this, then this is why they were moved.
Add a proper regexp to represent them, according to the mke2fs.conf(5) documentation. Fix the lazy_itable_init, and auto_64-bit_support keys of fs_types to use this regexp, as they are parsed as boolean.
According to the mke2fs.conf(5) documentation, all the entries that appear in the various tags in the [fs_types] stanza may be used also in the [default] section; hence: - fold fs_types_entry into common_entry - move almost all the options (except fs_type, and undo_dir) from defaults_entry to common_entry so the options apply to both cases. Also, in an attempt to make the list of options slightly maintainable, add few lists with names of options with common types (list, int, bool).
Add more common entries for the [defaults] stanza, or inside a [fs_types] tag, fixing the types to match documentation/code. This does not cover all the possible entries available though.
Handle the two documented tags of it.
ptoscano
force-pushed
the
mke2fs-improvements
branch
from
82d0352 to
8a19daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[defaults]and the tags in[fs_types][options]stanza