Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fails to parse latest java8u131 java.security file #468

Closed
qs5779 opened this issue May 18, 2017 · 2 comments
Closed

fails to parse latest java8u131 java.security file #468

qs5779 opened this issue May 18, 2017 · 2 comments
Labels
improvement lens

Comments

@qs5779
Copy link

qs5779 commented May 18, 2017

java8u131_java.security.txt

$ /opt/puppetlabs/puppet/bin/augtool -At "Properties.lns incl /home/jim/Downloads/java8u131_java.security"
augtool> print /files/home/jim/Downloads/java8u131_java.security
augtool> errors
Error in /home/jim/Downloads/java8u131_java.security:1.1 (parse_failed)
Iterated lens matched less than it should
Lens: /opt/puppetlabs/puppet/share/augeas/lenses/dist/properties.aug:50.25-.100:
Last matched: /opt/puppetlabs/puppet/share/augeas/lenses/dist/util.aug:134.6-.14:
Next (no match): /opt/puppetlabs/puppet/share/augeas/lenses/dist/util.aug:22.27-.34:
augtool> quit
jim@xx:~/my/dev/pup/wtfo
$ /opt/puppetlabs/puppet/bin/augtool --version
augtool 1.4.0 http://augeas.net/
Copyright (C) 2007-2011 David Lutterkort
License LGPLv2+: GNU LGPL version 2.1 or later
http://www.gnu.org/licenses/lgpl-2.1.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David Lutterkort
@qs5779
Copy link
Author

qs5779 commented May 18, 2017 •
edited
Loading

I just discovered the file I was provided was a dos crlf style file. I converted it to unix LF and it parsed fine. I am new to augeas, so if the tool is line ending sensitive. Then please mark this issue, as user error. Thanks.

@raphink
Copy link
Member

raphink commented May 22, 2017

Indeed, the Properties.lns lens doesn't support DOS eol at the moment. I would welcome a PR to fix this if you want to get a go at it.

lutter added a commit to lutter/augeas that referenced this issue Sep 29, 2017
@lutter
Properties: accept DOS line endings
9408f2b 
We now allow /\r?\n/ in line endings. The regular expressions preceding eol
and hard_eol are a little tighter than they really need to be to avoid
ambiguous concatenations as they generally result from removing \r from
allowable values. If that turns out to be a problem, we need to refine them
further.

Fixes hercules-team#468
@lutter lutter mentioned this issue Sep 29, 2017
Merged
lutter added a commit to lutter/augeas that referenced this issue Sep 29, 2017
@lutter
Properties: accept DOS line endings
6face3f 
We now allow /\r?\n/ in line endings. The regular expressions preceding eol
and hard_eol are a little tighter than they really need to be to avoid
ambiguous concatenations as they generally result from removing \r from
allowable values. If that turns out to be a problem, we need to refine them
further.

Fixes hercules-team#468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement lens
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domcleal @raphink @qs5779