Closed
Conversation
<NixOS/nixpkgs@dfd98a5> (cherry picked from commit 3bbcca6)
(cherry picked from commit bf47eae)
(cherry picked from commit e0baa4c)
Member
Author
|
Maybe I just shouldn't have asked, but this is just weird now. |
|
Sorry, don't know why I missed replying to this! Cherry-picking these is absolutely okay. I'll clean up what's still relevant and resubmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bb010g, I've cherry-picked some of your commits from #183. Is that ok?
I have not included the following commits:
I might have another look at the testing, if you think those changes are useful, but for a first step, here's some of your commits I could merge right away. (And one of mine I guess)