add vendor and darwin support #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢您的提交，但我认为没必要添加vendor |
|
@henson 建议还是加一下，因为Golang和其他语言的区别在于对版本库的依赖缺乏版本相关信息，一旦依赖的仓库出现问题，可能会造成项目无法编译，因此，一般Golang的项目都会内置vendor，这个也是1.9以后Golang语言级别的规范。 |
|
我也认为不需要vendor，现在使用gomod，有默认的proxy.golang.org,自己使用过的包是不会丢失的，倒是可以提一个 go.mod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add darwin support and add vendor path.